Skip to content

Remove deprecated 'use_scheduled_task' option from Manage Windows Updates - Ansible Default template#778

Open
sshockley wants to merge 1 commit into
theforeman:masterfrom
sshockley:patch-1
Open

Remove deprecated 'use_scheduled_task' option from Manage Windows Updates - Ansible Default template#778
sshockley wants to merge 1 commit into
theforeman:masterfrom
sshockley:patch-1

Conversation

@sshockley

Copy link
Copy Markdown

The 'use_scheduled_task' option was removed from ansible.windows with the release of 2.0.0.

Overview of Changes

  • The use_scheduled_task option caused current versions of ansible.windows to fail to run Manage Windows Updates.

Implementation Considerations

  • We may want to inform users if they need to upgrade from ansible.windows v1.14.0 or before, but I suspect few are using this.

Testing Steps

  • I tested this successfully with Windows Server 2022/2025 and Windows 10 Enterprise. Foreman is 3.17.0 on Alma 9.7, Ansible Core 2.16.14-3, ansible.windows 3.3.0.

Checklists

  • I am familiar with the contributing guidelines.
  • I have added relevant tests for my changes.
  • I have updated the documentation accordingly.

Are there tests for job templates? If so please point me to them or their documentation, I'll be glad to add them. Same with documentation, the only docs I found were in the template itself.

The 'use_scheduled_task' option was removed from ansible.windows with the release of 2.0.0.
@sshockley

Copy link
Copy Markdown
Author

Hi, can I get some assistance with the tests? It's not clear to me why they're failing. Can you also verify if the tests are functional? I noticed that #777 is failing in much the same way, and there have been no successful runs of the Ruby Testing test since October 29. Thanks!

@adamruzicka

Copy link
Copy Markdown
Contributor

Thank you for bringing that up, the test failures should be addressed in #779 , no need to worry about those anymore.

@adamruzicka

Copy link
Copy Markdown
Contributor

Technically we don't really do release notes for plugins. Could you please write a post announcing this change on our community forum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants